E&S CVS Commit: PyProtocols - Dispatcher and GenericFunction now use a 'combine()' method in place of a

pje at eby-sarna.com pje at eby-sarna.com
Sun Jan 9 19:52:00 EST 2005


Module Name:	PyProtocols
Committed By:	pje
Date:		Mon Jan 10 00:51:57 UTC 2005

Modified Files:
	PyProtocols/src/dispatch: __init__.py combiners.py combiners.txt
	    functions.py
	PyProtocols/src/protocols/tests: test_dispatch.py

Log Message:
Dispatcher and GenericFunction now use a 'combine()' method in place of a
'method_combiner' attribute.  The intent is to allow subclassing in place
of using generic method combiners, because in practice the needs of
generic functions and dispatchers are quite different.  So, apart from
the default strategy, there's no need to reuse combination strategies
across the two types.  'combiners.MapCombiner' is now
'combiners.MapDispatcher', a subclass of Dispatcher.  Instead of creating
a custom Dispatcher with a MapCombiner, you should now just instantiate
your custom MapDispatcher.  (This change will break some tests in PEAK,
but I will fix them soon after this checkin.)


To view diffs of this commit, you can use the following URL(s):
http://cvs.eby-sarna.com/PyProtocols/src/dispatch/__init__.py.diff?r1=1.11&r2=1.12
http://cvs.eby-sarna.com/PyProtocols/src/dispatch/combiners.py.diff?r1=1.1&r2=1.2
http://cvs.eby-sarna.com/PyProtocols/src/dispatch/combiners.txt.diff?r1=1.1&r2=1.2
http://cvs.eby-sarna.com/PyProtocols/src/dispatch/functions.py.diff?r1=1.19&r2=1.20
http://cvs.eby-sarna.com/PyProtocols/src/protocols/tests/test_dispatch.py.diff?r1=1.26&r2=1.27

To generate a diff of this commit:
cvs rdiff -r1.11 -r1.12 PyProtocols/src/dispatch/__init__.py
cvs rdiff -r1.1 -r1.2 PyProtocols/src/dispatch/combiners.py \
    PyProtocols/src/dispatch/combiners.txt
cvs rdiff -r1.19 -r1.20 PyProtocols/src/dispatch/functions.py
cvs rdiff -r1.26 -r1.27 PyProtocols/src/protocols/tests/test_dispatch.py

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.




More information about the source-changes mailing list