E&S CVS Commit: PEAK - The 'events.IEventSource' interface now returns a 'canceller' function

pje at eby-sarna.com pje at eby-sarna.com
Thu Mar 18 17:08:00 EST 2004


Module Name:	PEAK
Committed By:	pje
Date:		Thu Mar 18 22:07:28 UTC 2004

Modified Files:
	PEAK: CHANGES.txt
	PEAK/src/peak/events: event_threads.py interfaces.py io_events.py
	    sources.py twisted_support.py
	PEAK/src/peak/events/tests: test_events.py test_twisted.py
	PEAK/src/peak/running/tests: __init__.py

Log Message:
The 'events.IEventSource' interface now returns a 'canceller' function
from the 'addCallback()' method, allowing you to cancel a previously-
scheduled callback.  This fixes a memory leak and performance problem with
'events.AnyOf()', which previously could accumulate unneeded callbacks on
the sources it was monitoring.  Note that if you have developed any custom
event sources with 'addCallback()' methods, you must make sure that they
return a canceller from now on.


To view diffs of this commit, you can use the following URL(s):
http://cvs.eby-sarna.com/PEAK/CHANGES.txt.diff?r1=1.133&r2=1.134
http://cvs.eby-sarna.com/PEAK/src/peak/events/event_threads.py.diff?r1=1.10&r2=1.11
http://cvs.eby-sarna.com/PEAK/src/peak/events/sources.py.diff?r1=1.10&r2=1.11
http://cvs.eby-sarna.com/PEAK/src/peak/events/interfaces.py.diff?r1=1.15&r2=1.16
http://cvs.eby-sarna.com/PEAK/src/peak/events/io_events.py.diff?r1=1.8&r2=1.9
http://cvs.eby-sarna.com/PEAK/src/peak/events/twisted_support.py.diff?r1=1.8&r2=1.9
http://cvs.eby-sarna.com/PEAK/src/peak/events/tests/test_events.py.diff?r1=1.13&r2=1.14
http://cvs.eby-sarna.com/PEAK/src/peak/events/tests/test_twisted.py.diff?r1=1.4&r2=1.5
http://cvs.eby-sarna.com/PEAK/src/peak/running/tests/__init__.py.diff?r1=1.18&r2=1.19

To generate a diff of this commit:
cvs rdiff -r1.133 -r1.134 PEAK/CHANGES.txt
cvs rdiff -r1.10 -r1.11 PEAK/src/peak/events/event_threads.py \
    PEAK/src/peak/events/sources.py
cvs rdiff -r1.15 -r1.16 PEAK/src/peak/events/interfaces.py
cvs rdiff -r1.8 -r1.9 PEAK/src/peak/events/io_events.py \
    PEAK/src/peak/events/twisted_support.py
cvs rdiff -r1.13 -r1.14 PEAK/src/peak/events/tests/test_events.py
cvs rdiff -r1.4 -r1.5 PEAK/src/peak/events/tests/test_twisted.py
cvs rdiff -r1.18 -r1.19 PEAK/src/peak/running/tests/__init__.py

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.




More information about the source-changes mailing list